Closed chetanchilhate closed 3 years ago
@knjk04 let me if any change is needed
@knjk04 added test cases have look while writing test cases, I found one issue with Book constructor we are checking not null we should also check list should not be empty if does we should throw IllegalArgumentException book must have at least one author
@knjk04 I have made suggested changes have look let me know if I missed anything I will fix it
Summary of change
Lazy load authors in book and books in author
Related issue
Closes #20
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace