Shivansh Added issue 11

shivansh29 commented 3 years ago

Summary of change

[Please briefly describe what you have changed.]

Related issue

Closes #[issue number]

Pull request checklist

Please keep this checklist in & ensure you have done the following:

[x] Read, understood and adhered to our contributing document.
- [x] Ensure that you were first assigned to a relevant issue before creating this pull request
- [x] Ensure code changes pass all tests
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace

knjk04 commented 3 years ago

Thanks for working on this. Could you please fill in the PR description (see a merged in PR if you need an example)?

shivansh29 commented 3 years ago

could you give a link of a merged PR

knjk04 commented 3 years ago

@shivansh29 Any of these: https://github.com/Project-Books/books-api/pulls?q=is%3Apr+is%3Amerged+

knjk04 commented 3 years ago

I noticed that your source branch is main. Could you please create a new branch (git branch -m <new-branch-name>)? You'll need to create a PR as this one will be invalid.

If you need a hand with anything, feel free to reach out to us on our help channel on Slack

Project-Books / books-api