Validate ISBN13 #5 - Githubissues

vAdyar commented 3 years ago

Summary of change

Added a utility method to check if a String is a valid ISBN 13 value. Added 2 new classes as a part of this change.

Closes #5

Please keep this checklist in & ensure you have done the following:

[x] Read, understood and adhered to our contributing document.
- [x] Ensure that you were first assigned to a relevant issue before creating this pull request
- [x] Ensure code changes pass all tests
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

knjk04 commented 3 years ago

As we're now using DGS and Gradle, could you please rebase to bring your branch level with main?

vAdyar commented 3 years ago

Sure. Getting my forked repo to the same level with all the changes mentioned. Closing this PR and will create a new one.