Closed MarcinMaruszak closed 3 years ago
Thanks for this.
I noticed you took out the pull request checklist. In your next pull request, could you please keep it in?
Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
This is one of the checkboxes. Note that you'll need to include the issue number in your branch name. This should be find-books-by-publisher-57
. You can rename your branch with git branch -m <new-branch-name>
. You will have to create another pull request, however.
If you need a hand with this or anything else in the process, feel free to ask by creating a new GitHub Q&A discussion or on our Slack #help channel.
Please keep this checklist in & ensure you have done the following:
[ ] Read, understood and adhered to our contributing document.
[ ] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[ ] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[ ] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
[ ] Set this pull request to 'draft' if you are still working on it
[ ] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub
This reverts commit 4ff28933
Summary of change
added to schema and find by publisher
Related issue
Closes #57
sorry, still learning how to use github so i deleted last branch, i thing it might be ok now.