Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 60 forks source link

Validate ISBN 13 #5 #68

Closed vAdyar closed 3 years ago

vAdyar commented 3 years ago

Summary of change

Added a utility method to check is a String is a valid ISBN 13 value. Added 2 new classes as a part of this change.

  1. ISBNValidator class.
  2. InvalidISBNException class.

Related issue

Closes #5

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

knjk04 commented 3 years ago

Thanks for this. Unfortunately, the branch name is still not quite right

Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

You're missing the issue number at the end. This should be validate-isbn13-5.