Add series issue 6

[kev711]

Summary of change

If a book is in a series, it should be possible to see:

Its position in the series com.karankumar.booksapi.repository.BookRepository.getBookPositionInBookSeries() The name of the series (e.g. 'Harry Potter' for the Harry Potter books) com.karankumar.booksapi.repository.BookRepository.getAllBookSeriesForBook() Other books in the same series com.karankumar.booksapi.repository.BookSeriesMappingRepository.getAllBooksByBookSeries()

Related issue

Closes #6

Pull request checklist

Please keep this checklist in & ensure you have done the following:

• [x] Read, understood and adhered to our contributing document.

  • [x] Ensure that you were first assigned to a relevant issue before creating this pull request
  • [x] Ensure code changes pass all tests

• [x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.

• [x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request

• [x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

• [x] Set this pull request to 'draft' if you are still working on it

• [x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

[knjk04]

Thanks for working on this! I'll review this shortly!

[kev711]

I am working on resolving the other comments...

[kev711]

Thanks for working on this! I've left a few comments and made a few changes (so I recommend pulling first).

Could you please add a Flyway migration?

Hi @knjk04, I added scripts for Flyway migration. How do you test them ?

Also, made changes for other comments.

[knjk04]

Hi @kev711,

We're using integration tests for that. I noticed you have some DataJpaIntegration tests. I'll need to review this closer, but that should be fine

[knjk04]

Would it be possible to resolve the merge conflicts?

[kev711]

Working on it...

[kev711]

Merge conflicts resolved.

[knjk04]

There are quite a few unrelated changes to the issue you worked on in this PR diff. Would it be possible to create a new PR to make it easier to review?

[kev711]

Sure.

[kev711]

Closing this one, since its not allowing me to open a new one.