Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 60 forks source link

Unable to find publisher for book #87

Closed knjk04 closed 2 years ago

knjk04 commented 3 years ago
  "data": {
    "findAllBooks": [
      {
        "title": "Harry Potter and the Philosopher's stone",
        "authors": [],
        "publisher": null
      },

The findAllBooks query should show the publisher for the above book as 'Bloomsbury'.

Query:

{
   findAllBooks {
     title
     authors {
       fullName
       about
     }
     publisher {
       name
     }
    }
}
maines-pet commented 3 years ago

Hi, I would like to work on this. I've identified the issue in the book.graphqls causing this issue.

knjk04 commented 2 years ago

Hi @maines-pet , we can assign you to this after we have merged in your work for your currently assigned issue (see contributing document)

maines-pet commented 2 years ago

Hi, can I now take this on?

knjk04 commented 2 years ago

Hi @maines-pet, sure! Thanks again!

maines-pet commented 2 years ago

Hi @knjk04, picking up from #125, can you please check if my approach would work on this issue?

knjk04 commented 2 years ago

Hi @maines-pet, apologies for the confusion, I've been thinking about this further. Let's keep the many-to-many relationship with the join table and references on both sides. We may need to update the type of publisher field in the book.graphqls schema to a list

maines-pet commented 2 years ago

In that case, will PR #125 be able to address the requirements now? I'm not sure if it's possible to reopen a closed PR in github.

knjk04 commented 2 years ago

@maines-pet Yes, sorry for the mix-up. I've reopened it