Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 60 forks source link

Add series issue 6 #98

Closed kev711 closed 3 years ago

kev711 commented 3 years ago

Summary of change

If a book is in a series, it should be possible to see:

Its position in the series com.karankumar.booksapi.repository.BookRepository.getBookPositionInBookSeries() The name of the series (e.g. 'Harry Potter' for the Harry Potter books) com.karankumar.booksapi.repository.BookRepository.getAllBookSeriesForBook() Other books in the same series com.karankumar.booksapi.repository.BookSeriesMappingRepository.getAllBooksByBookSeries()

Related issue

Closes #6

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

kev711 commented 3 years ago

@knjk04 Created a new one for this issue.

knjk04 commented 3 years ago

Thanks for working on this. I'm still reviewing this

knjk04 commented 3 years ago

@kev711 How are you getting on with this?

kev711 commented 3 years ago

@kev711 How are you getting on with this?

The flyway migration for AUTHOR is failing. Trying to resolve. Also, how do I use -dev profile for starting the application ?

knjk04 commented 3 years ago

The flyway migration for AUTHOR is failing.

Could you send the output? It's fine on my end.

Also, how do I use -dev profile for starting the application ?

What are you using the run the application (e.g. IntelliJ, Eclipse, terminal, etc.)?

knjk04 commented 3 years ago

@kev711 Following up on this

kev711 commented 3 years ago

Hi @knjk04 Due to time commitments I won't be able to add to this work at this time. Thanks for working with me!

knjk04 commented 3 years ago

@kev711 Thanks for letting us know