search

Project-Chirp / chirp-frontend

Frontend of Chirp
2 stars 3 forks source link

T102: Fix emoji picker overflow bug #103

Closed Dennull closed 3 months ago

Dennull commented 4 months ago

This resolves #102.

Context

There is a bug with the emoji picker when it's used in our modals, specifically PostButtonModal and RepliesModal. The bug makes the emoji picker overflow so that the entire modal isn't visible (ie. it has a scroll bar)

Solution

The solution is to change the overflow to visible in the dialog content div. Additional refactors were also made to get rid of an MUI Card component that was being used in the RepliesModal because the styling of the card when overflow was visible made the modal look different

NasihNazeem commented 3 months ago

Don't really have anything to critique with these changes, works as expected. Good work bro