Closed xkanzeon closed 1 year ago
Yeah I'm kinda thinking that having both increment and decrement would be nice. Especially for filters that use all of the filter levels. Then you wouldn't have to loop through the entire list to go back one level.
I'm also wondering if we even need a default hotkey for this. Seems like more of an advanced feature and I can see someone accidentally changing their level.
As far as the code, you should use TextColor
instead of ITEM_QUALITY_NONE
.
Also could be cool to use multiple colors to break up the text a little bit. Something like this:
PrintText(TextColor::Gold, "Filter level: ÿc00 - Show All Items");
would look like:
Maybe have level 0 be a different color from the rest too? So you can easily tell you're at the "start"
Removed default binding(s)
Split into increment/decrement, but not wrapping anymore (partially because of the next point)
Added direct level setting with Ctrl + Numpad 0 - 9
This isn't advertised anywhere. I couldn't think of a good spot for it that wouldn't be too crowded.
Added a new bind to swap back and forth between current and previous strictness levels. I kind of added onto whoever's hacky filter reload to be able to remember previous filter when selected from the settings menu. It...works.
You've got your color separation now. Enjoy.
Edit: I totally forgot to recolor level 0 differently. Without the wrapping, this seems less significant, though, so I'll pretend it was on purpose. Fixed.
Edit2: Reworded the settings from "Strictness" to just "Level" to be more suitable for general use. Also added a note for the Numpad use to the Interaction tab. Lots of free space there, and it's at least sort of relevant.
Couple of things:
MapNotify::OnKey()
)
if (key == settings->reloadConfigCtrl && ctrlState || key == settings->reloadConfig && !ctrlState)
Should be a pretty self-explanatory change.
More than happy to adjust for style preferences. For example, I was on the fence about leaving the number in with the text message. Eventually figured it would help prevent ambiguity with level names though.
Defaulting to
Numpad +
to be out of the way, but easily accessed with with the mouse hand.Also considered/ing separate increment/decrement bindings. At the time of writing, it felt like that would be too many little things from a usage standpoint. Would love either a correction or confirmation on that.