Closed GenjisRevenge closed 8 months ago
Wow this is awesome
I'll look into this soon and check it out, haven't had time to go through it.
Hey @GenjisRevenge, I don't know if you've been keeping up with the dev streams but we've added difficulty filter buttons to the join game screen. As part of this, the underlying behavior of the "GS" text in the game list has also changed. What this means for this PR:
If you have any questions please let me know. Happy to help!
Hi @fergushev
I updated the branch: removed the difficulty filter and getting the game server number from the new location. However, I didn't try to log in with these modifications to the live server. You have to test run it before deployment.
@GenjisRevenge Looks good to me. Thanks for the update!
This feature allows the player to select game servers in the lobby with filter strings like
gs:1,2 baal
.I haven't tested this change because the README.md of this repo advises against it:
The bulk of the logic (the
ParsedFilterString
class) was implemented in a small standalone project where I tested it manually so that shouldn't be extremely buggy. You have to make sure that the untested changes (in theGameFilter
class) work as intended when the game goes online and enters the lobby.