Project-Diablo-2 / BH

A modified version of slashdiablo's BH for Project Diablo 2
GNU Affero General Public License v3.0
23 stars 23 forks source link

Allow `%NL%` within shops #32

Closed xkanzeon closed 1 year ago

xkanzeon commented 1 year ago

Mentioned a few times within the lootfilter channel on Discord.

The primary use seems like it would be for a "revealed" version of gambling in a less eyesore manner. Woflie referred me to the discussion way back on %NL% being disabled for reasons. This doesn't seem as though it would really be subject to the same issue, but if that's not true, just say the word and it'll go away.

Positive side-effect: Adds Alkor to the SHOP condition. Currently Akara has his spot stolen and is used twice. Not that anyone ever goes there, but...yeah.

Edit: While functional, this is still subject to name length limits. I'd like to include an exclusion to shops for said limit (or at least extend it), but would also like input on that. If it's deemed reasonable, I can push a commit that I have ready for that. I could see this having use beyond just the gambling screen. Most notably filter-made information on items from Akara (brief README style). I could also see the argument of this being abused in some way for some reason.

Ideal scenario, example courtesy of Wolfie: ![image](https://github.com/Project-Diablo-2/BH/assets/72973313/41b78b42-4126-4f9a-b5fb-3de283abe944)

Edit 2: I went ahead and pushed that limit increase. A little less processing involved with the implementation, and I can adjust the change based on feedback. I used an arbitrary 500 character limit which still seems like overkill to me, and was chosen only because of the gambling use case for amulets coming out to ~400 characters if done "formally."

Maaaaaarrk commented 1 year ago

+1 for this please

WolfieeifloW commented 1 year ago

Would also love for this to be implemented.