xijin1337
commented
5 days ago I would also like to ask about multilingual support. I created a translation in Polish, but BH does not display Polish characters except "Ś"
Open Vahsify opened 1 month ago
xijin1337
commented
5 days ago I would also like to ask about multilingual support. I created a translation in Polish, but BH does not display Polish characters except "Ś"
xijin1337
commented
5 days ago Hello. I saw that translation lines were added to tbl PD2. I translated PD2 into Russian. Would you like to add multilingual support to BH.dll? It was made by Aglophotis in her fork (https://github.com/Aglophotis/BH ). The only noticed problem with this fork is that Windows 7 does not support multi-languages.
Do you have a compiled version of BH from Aglophotis? If so, please post.
Vahsify
commented
4 days ago Hello. I saw that translation lines were added to tbl PD2. I translated PD2 into Russian. Would you like to add multilingual support to BH.dll? It was made by Aglophotis in her fork (https://github.com/Aglophotis/BH ). The only noticed problem with this fork is that Windows 7 does not support multi-languages.
Do you have a compiled version of BH from Aglophotis? If so, please post.
Hello. I asked Aglophotis to post a release with fixes.
Canite
commented
3 days ago The fork created by Aglophotis has changes unrelated to translation (like increasing the max item name size) that will not be included in the main branch for PD2. I also noticed a lot of changes that don't make sense to me and every commit only says "Minor change" with no description of what actually changed. If we were to include these changes, she would need to make a pull request and I would have to review it and modify. Remember also that compiled versions of BH.dll outside of what's provided by the launcher will not work online
Aglophotis
commented
3 days ago Hello. I saw that translation lines were added to tbl PD2. I translated PD2 into Russian. Would you like to add multilingual support to BH.dll? It was made by Aglophotis in her fork (https://github.com/Aglophotis/BH ). The only noticed problem with this fork is that Windows 7 does not support multi-languages.
Do you have a compiled version of BH from Aglophotis? If so, please post.
Hi, i made a release with the latest edits. If you have any questions, you can create a issue in github in my repository or write a to discord. https://github.com/Aglophotis/BH/releases/tag/0.1.0
Aglophotis
commented
3 days ago The fork created by Aglophotis has changes unrelated to translation (like increasing the max item name size) that will not be included in the main branch for PD2. I also noticed a lot of changes that don't make sense to me and every commit only says "Minor change" with no description of what actually changed. If we were to include these changes, she would need to make a pull request and I would have to review it and modify. Remember also that compiled versions of BH.dll outside of what's provided by the launcher will not work online
If you are really considering the option of implementing multilingual support, then I can bring my changes to a cleaner and better solution than they are now. There are pieces of code that need to be made more universal. In fact, the whole feature was made to just work, since there is no c++ development experience or knowledge of how diablo works from the inside.
Canite
commented
3 days ago The fork created by Aglophotis has changes unrelated to translation (like increasing the max item name size) that will not be included in the main branch for PD2. I also noticed a lot of changes that don't make sense to me and every commit only says "Minor change" with no description of what actually changed. If we were to include these changes, she would need to make a pull request and I would have to review it and modify. Remember also that compiled versions of BH.dll outside of what's provided by the launcher will not work online
If you are really considering the option of implementing multilingual support, then I can bring my changes to a cleaner and better solution than they are now. There are pieces of code that need to be made more universal. In fact, the whole feature was made to just work, since there is no c++ development experience or knowledge of how diablo works from the inside.
Yes, that would be nice. From what I saw, your implementation looks good, I'll just have to go through it a bit. But we have been slowly working on adding multilingual support in game and I would like to extend that to BH as well.
Aglophotis
commented
2 days ago The fork created by Aglophotis has changes unrelated to translation (like increasing the max item name size) that will not be included in the main branch for PD2. I also noticed a lot of changes that don't make sense to me and every commit only says "Minor change" with no description of what actually changed. If we were to include these changes, she would need to make a pull request and I would have to review it and modify. Remember also that compiled versions of BH.dll outside of what's provided by the launcher will not work online
If you are really considering the option of implementing multilingual support, then I can bring my changes to a cleaner and better solution than they are now. There are pieces of code that need to be made more universal. In fact, the whole feature was made to just work, since there is no c++ development experience or knowledge of how diablo works from the inside.
Yes, that would be nice. From what I saw, your implementation looks good, I'll just have to go through it a bit. But we have been slowly working on adding multilingual support in game and I would like to extend that to BH as well.
Well, I'll open a pull request when I finalize the nuances and bring the code to the product state.
Hello. I saw that translation lines were added to tbl PD2. I translated PD2 into Russian. Would you like to add multilingual support to BH.dll? It was made by Aglophotis in her fork (https://github.com/Aglophotis/BH ). The only noticed problem with this fork is that Windows 7 does not support multi-languages.