Project-Epoch / TrinityCore

TrinityCore Open Source MMO Framework (master = 8.3.7.35662, 3.3.5 = 3.3.5a.12340)
http://www.trinitycore.org
GNU General Public License v2.0
4 stars 7 forks source link

Health and Power Regeneration Rewrite #26

Closed kaytotes closed 3 months ago

kaytotes commented 3 months ago

This is essentially a breaking change and is custom tailored to Epoch so shouldn't really be PRed anywhere else but required so much to change I couldn't be bothered properly marking it as such. Womp, womp.

This PR rewrites Player, Creature and Pet health regeneration to be a hybrid between TBC and Vanilla while also fixing logic bugs and inaccuracies. As well as disabling client side features like power prediction to give a proper TBC / Vanilla style 2 second tick based health and mana regen for players.

Wrath / TBC mana and health regeneration for both players and pets feels bad so we decided to port regeneration rates for those using the Vanilla spirit to HP / MP regen formula. For this to properly reflect in any other client this requires edits that we are not providing but are relatively simple lua.

The same applies for hunter focus which now correctly displays in ticks with no client side prediction.