fix: error happen when allocate iluvatar device

Project-HAMi / HAMi

Heterogeneous AI Computing Virtualization Middleware

http://project-hami.io/

Apache License 2.0

963 stars 199 forks source link

Closed lijm87 closed 1 month ago

lijm87 commented 2 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: error 'index out of range [1] with length 1' happen when allocate iluvatar device

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 2 months ago

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/device/iluvatar/device.go	0.00%	1 Missing :warning:

Flag	Coverage Δ
unittests	`26.99% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/device/iluvatar/device.go	`18.42% <0.00%> (ø)`

wawa0210 commented 1 month ago

@lijm87

This PR seems to have some problems on ut and needs to be fixed. It will be released today. Do you have time to follow up?

lijm87 commented 1 month ago

@lijm87

This PR seems to have some problems on ut and needs to be fixed. It will be released today. Do you have time to follow up?

done