search

Project-HAMi / HAMi

Heterogeneous AI Computing Virtualization Middleware
http://project-hami.io/
Apache License 2.0
983 stars 200 forks source link

Fix HAMi image is too large and uses inappropriate base image #505

Closed wawa0210 closed 2 months ago

wawa0210 commented 2 months ago

What type of PR is this?

/kind bug

image

Changes introduced by this pr https://github.com/Project-HAMi/HAMi/pull/492

This PR modifies the final base image of hami from nvidia/cuda:12.4.1-base-ubuntu22.04 to nvidia/cuda:12.2.0-devel-ubuntu20.04, and the image size becomes 3.1G.

We only need the image nvidia/cuda:12.4.1-base-ubuntu22.04

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

wawa0210 commented 2 months ago

@zoyopei Can you help me review this pr？

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 26.99% <ø> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

wawa0210 commented 2 months ago

the master branch is unmaintainable