Closed lijm87 closed 1 month ago
thanks:) are you using iluvatar devices in HAMI?
/approve
please fix go-lint CI, so it can be integrated
thanks:) are you using iluvatar devices in HAMI?
yes
please fix go-lint CI, so it can be integrated
done
@lijm87 We also need to reabse this PR into a single commit, ths last step 😄
All modified and coverable lines are covered by tests :white_check_mark:
Flag | Coverage Δ | |
---|---|---|
unittests | 28.30% <100.00%> (+0.68%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing lines | Coverage Δ | |
---|---|---|
pkg/device/iluvatar/device.go | 31.89% <100.00%> (+13.47%) |
:arrow_up: |
@lijm87 We also need to reabse this PR into a single commit, ths last step 😄
done
@lijm87 thanks your contribution, nice job 👍
What type of PR is this? /kind bug
What this PR does / why we need it: fix: error 'index out of range [1] with length 1' happen when allocate iluvatar device fix: exception occurred while creating multiple pods with iluvatar gpu concurrently
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: