Project-HAMi / HAMi

Heterogeneous AI Computing Virtualization Middleware
http://project-hami.io/
Apache License 2.0
956 stars 197 forks source link

fix: assgin to wrong devices when 1 pod has 2+ containers request GPU #593

Closed joy717 closed 2 weeks ago

joy717 commented 2 weeks ago

What type of PR is this?

/kind bug

What this PR does / why we need it: fix wrong quota for fitInDevices

Which issue(s) this PR fixes: Fixes #592

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 27.22% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/score.go 67.61% <100.00%> (+0.37%) :arrow_up:
archlitchi commented 2 weeks ago

yes, thats' a nice fix:)

archlitchi commented 2 weeks ago

/approve