Project-Lavinia / Lavinia-client

React application for simulating seat distribution in an election.

https://lavinia.no

MIT License

9 stars 4 forks source link

Show diff on settings change #249

Closed Log234 closed 4 years ago

Log234 commented 4 years ago

Description

The difference column in Election Overview should always be show if settings are different from the default settings.

Issues closed

Closes #240

cypress[bot] commented 4 years ago

Test summary

826 • 0 • 0 • 0

Run details


Project	Lavinia-client
Status	Passed
Commit	79320944e2
Started	Aug 26, 2020 8:51 AM
Ended	Aug 26, 2020 9:39 AM
Duration	48:02 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] commented 4 years ago

Test summary

826 • 0 • 0 • 0

Run details


Project	Lavinia-client
Status	Passed
Commit	bfd07e3760 ℹ️
Started	Aug 26, 2020 9:02 AM
Ended	Aug 26, 2020 9:48 AM
Duration	45:17 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

simendag commented 4 years ago

This isn't really keeping track of whether settings changed; but whether they are different from the original, but I suppose it's better than how things are now. I don't particularly like us adding to the already quite bloated state, but I suppose there is no alternative.

Log234 commented 4 years ago

Here is an overview of what got changed by this pull request:


Complexity decreasing per file
==============================
+ src/utilities/conditionals.ts  -1

See the complete overview on Codacy