fix: Add missing parties to each district

Log234 commented 2 years ago

Currently, the table District distribution of seats may show incorrect data, due to not every party receiving votes in every district. The consequence of this is that the values to the right of the missing party is shifted one to the left for each missing party. To fix this, this PR simply adds missing parties to each district with 0 votes, which ensures that the values end up in the correct columns.

The PR also corrects some table sizes and pagination to ensure all districts can be show, even when there are more than 19 districts in an election (see 1945 and 1949).

cypress[bot] commented 2 years ago

Test summary

0 • 827 • 0 • 0

Run details


Project	Lavinia-client
Status	Failed
Commit	78bce63bc6 ℹ️
Started	Mar 7, 2022 7:45 AM
Ended	Mar 7, 2022 8:04 AM
Duration	19:30 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 94

View run in Cypress Dashboard ➡️

Failures

	cypress/integration/computation_modern_combinations_pt2.spec.ts		10
1	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 0, District threshold 0, Election threshold 0
2	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 0, District threshold 0, Election threshold 15
3	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 0, District threshold 15, Election threshold 0
4	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 0, District threshold 15, Election threshold 15
5	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 100, District threshold 0, Election threshold 0
6	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 100, District threshold 0, Election threshold 15
7	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 100, District threshold 15, Election threshold 0
8	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 0, Leveling seats 100, District threshold 15, Election threshold 15
9	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 500, Leveling seats 0, District threshold 0, Election threshold 0
10	ComputationMenu > Modern combinations > Presentation Restkvotienter, Year 2017, Algorithm SAINTE_LAGUE, Area factor 0, District seats 500, Leveling seats 0, District threshold 0, Election threshold 15
This comment includes only the first 10 test failures. See all 827 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard