Project-MONAI / GenerativeModels

MONAI Generative Models makes it easy to train, evaluate, and deploy generative models and related applications
Apache License 2.0
555 stars 78 forks source link

Clipping min and max values on scheduler #494

Closed virginiafdez closed 1 week ago

virginiafdez commented 1 month ago

The clip_sample option for the DDPM and DDIM schedulers clip the predicted noise between -1 and 1. This procedure was borrowed from the SD implementation, and it should be allowed for the user to specify them; for latent diffusion models, where ranges are ~Gaussian, clipping can hinder the training process. This is also in response to Discussion #492: https://github.com/Project-MONAI/GenerativeModels/discussions/492.