Open AHarouni opened 1 year ago
Hi @AHarouni ,
Thanks.
@AHarouni I completely agree with you, thank you for bringing it up.
I also think that we duplicate code for each fold, which is very inconvenient to use, as changing some parameters requires to change configs for each fold. I recommend changing that, instead of generating flat folders:
algoA_0
algoA_1
...
AlgoA_0
algoB_0
we can generate a nested structure, without duplicated code.
algoA
fold_0
fold_1
algoB
fold_0
fold_1
I also noticed the code is very similar across network architectures, may be we can factor that in also
this is partically due to the fact that algo code lives in monai-contributions, and it's hard to import from each other. I think we can move it to the core monai/apps/auto3dset. Then we can create common superclasses to subclass.
Currently Auto3d generates the same exact folders for each fold for each network. the only difference is hte fold arg in the config.
this causes lots of copy pasting across folds folders when there are some modifications / enhancements to add.
Ask Please simply generate single folder with scripts and code for all folds.
I also noticed the code is very similar across network architectures, may be we can factor that in also