Open qubvel opened 2 weeks ago
Hey! I would appreciate any comments on this đŸ¤— ping @ericspod @KumoLiu for visibility
Hi @qubvel Thanks again. Please double check places like this in setup.cfg have the updated information as your code mentions needed safetensors
. Is it possible to perhaps subclass these networks as well? I am hesitant to modify existing definitions as a general rule even though things like the model weights are unchanged. For example instead of changing AHNet
we would have class AHNetHub(AHNet, MonaiHubMixin): pass
. I'd like some feedback from others on this as well.
@ericspod thanks for the review, I will address the comments! At the moment it's a raw draft to know how you feel about this integration in general. Any comments on how to make it smooth are appreciated!
I'm not sure I got the point here, can you provide more details?
Is it possible to perhaps subclass these networks as well? I am hesitant to modify existing definitions as a general rule even though things like the model weights are unchanged.
Description
Hi! Amazing repo!
I made a draft with PytorchModelHubMixin for a few models in the repo. This mixin adds a few methods to make it possible to save/load models and share them with the HF hub.
Here is a short example:
I believe the repo and community may benefit from sharing pretrained models built with this framework! Let me know if it aligns with your roadmap, I will be happy to help you with implementation or to complete the PR!
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.