Add alpha parameter to DiceFocalLoss

Project-MONAI / MONAI

AI Toolkit for Healthcare Imaging

https://monai.io/

Apache License 2.0

5.5k stars 1.01k forks source link

Add alpha parameter to DiceFocalLoss #7841

Closed kephale closed 9 hours ago

kephale commented 2 weeks ago

Fixes https://github.com/Project-MONAI/MONAI/issues/7682.

Description

This PR introduces the alpha parameter from FocalLoss into DiceFocalLoss.

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[x] New tests added to cover the changes.
[x] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
[x] In-line docstrings updated.
[x] Documentation updated, tested make html command in the docs/ folder.

ericspod commented 1 week ago

Hi @kephale thanks for the contribution! I've made a few inline comments but in general it looks good. Please address these and I can come back to it for approval.

kephale commented 1 week ago

Okey doke, the requested changes have been addressed. I'm not sure what is going on with the min-dep tests because that part of the code hasn't been modified.

ericspod commented 1 week ago

The test fails are related to Numpy 2.0 being released a few days ago and we aren't compatible yet. I have a fix I need to push then these will work.

ericspod commented 6 days ago

I have pushed a temporary fix now so I'm rerunning your tests after merging dev into this branch.

ericspod commented 6 days ago

There is a DCO fail that you do need to fix, @kephale. The instructions are there if you click on the check.

kephale commented 1 day ago

The DCO should be addressed.

KumoLiu commented 20 hours ago

/build

KumoLiu commented 18 hours ago

Hi @ericspod, do you have any other comments on this one?