Scheduler Clip Fix - Githubissues

virginiafdez commented 1 week ago

Fixes # .

Description

Fixes a bug in the inferer and adds clipping parameters to the DDIM/DDPM schedulers.

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
[ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
[ ] In-line docstrings updated.
[ ] Documentation updated, tested make html command in the docs/ folder.

ericspod commented 1 week ago

One of the fails is related to #7856.

ericspod commented 1 week ago

See #7857 for the fix that you might need here for the fails you're seeing with some tests.

ericspod commented 1 week ago

There are too many changes for Numpy 2.0 to do so I have #7859 to force a Numpy version <2.0.

ericspod commented 1 week ago

@KumoLiu @Nic-Ma I think we're good to merge this into this branch, @virginiafdez can then work on merging dev into it then finally the result into dev to complete the port. If you one of you could please trigger blossom we can do the last tests. Thanks!

Nic-Ma commented 1 week ago

/build

Project-MONAI / MONAI

Scheduler Clip Fix #7855

Description

Types of changes