Project-MONAI / MONAI

AI Toolkit for Healthcare Imaging
https://monai.io/
Apache License 2.0
5.73k stars 1.05k forks source link

Add utils for vista3d #7999

Closed yiheng-wang-nv closed 1 month ago

yiheng-wang-nv commented 1 month ago

This PR is a part of #7987

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

ericspod commented 1 month ago

I had very minor suggestions but otherwise looks fine.

KumoLiu commented 1 month ago

/build

KumoLiu commented 1 month ago

Hi @yiheng-wang-nv, please help take a look at the ci error.

[2024-08-09T10:27:16.069Z] ======================================================================
[2024-08-09T10:27:16.069Z] ERROR: test_cp_shape_0 (tests.test_vista3d_utils.TestGetLargestConnectedComponentMaskPoint)
[2024-08-09T10:27:16.069Z] ----------------------------------------------------------------------
[2024-08-09T10:27:16.069Z] Traceback (most recent call last):
[2024-08-09T10:27:16.069Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-09T10:27:16.069Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_utils.py", line 122, in test_cp_shape
[2024-08-09T10:27:16.069Z]     mask = get_largest_connected_component_mask_point(**input_data)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/transforms/utils.py", line 1240, in get_largest_connected_component_mask_point
[2024-08-09T10:27:16.069Z]     x, y, z = p.round().int().tolist()
[2024-08-09T10:27:16.069Z] RuntimeError: "round_cuda" not implemented for 'Long'
[2024-08-09T10:27:16.069Z] 
[2024-08-09T10:27:16.069Z] ======================================================================
[2024-08-09T10:27:16.069Z] ERROR: test_cp_shape_1 (tests.test_vista3d_utils.TestGetLargestConnectedComponentMaskPoint)
[2024-08-09T10:27:16.069Z] ----------------------------------------------------------------------
[2024-08-09T10:27:16.069Z] Traceback (most recent call last):
[2024-08-09T10:27:16.069Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-09T10:27:16.069Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_utils.py", line 122, in test_cp_shape
[2024-08-09T10:27:16.069Z]     mask = get_largest_connected_component_mask_point(**input_data)
[2024-08-09T10:27:16.069Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/transforms/utils.py", line 1240, in get_largest_connected_component_mask_point
[2024-08-09T10:27:16.069Z]     x, y, z = p.round().int().tolist()
[2024-08-09T10:27:16.069Z] RuntimeError: "round_cuda" not implemented for 'Long'
KumoLiu commented 1 month ago

/build