search

Project-MONAI / MONAILabel

MONAI Label is an intelligent open source image labeling and learning tool.
https://docs.monai.io/projects/label
Apache License 2.0
596 stars 191 forks source link

Add no scribbles model #1586

Closed matt3o closed 10 months ago

matt3o commented 11 months ago

I don't think this is the best approach to implement this behavior, however, it does work. I am open to implementing this in a completely different way if a maintainer can tell me how else to do this. As it is this PR adds a new model called "no_scribbles". If you add this model, the scribbles section is deactivated. For an interactive user study I simply wanted to eliminate all possible sources of confusion and errors, since it is click only (interactive DeepEdit style).

SachidanandAlle commented 11 months ago

Instead of adding a model..

you can add a flag.. similar to --conf scribbles=false

matt3o commented 11 months ago

Sweet, thanks for the suggestion! I just reworked it and now it works via --conf scribbles False. Default is True, so the behavior does not change unless desired.

matt3o commented 11 months ago

Is there any documentation somewhere for these kind of flags? Also this is only implemented for the radiology app for now, shall I add it to the other sample-apps as well?

SachidanandAlle commented 11 months ago

Looks Good.. for document.. currently I can suggest to add under radiology readme.md and show case this option to enable or disable scribbles

matt3o commented 11 months ago

@SachidanandAlle I added the info to the README as discussed above. Also I changed the semantics of the scribbles flag to true and false such that it now matches the other flags If all is good from your side, I think the code can be merged