search

Project-MONAI / MONAILabel

MONAI Label is an intelligent open source image labeling and learning tool.
https://docs.monai.io/projects/label
Apache License 2.0
623 stars 195 forks source link

DO NOT MERGE YET #1775

Closed sedghi closed 6 days ago

sedghi commented 2 weeks ago

Migrating the Monai Label plugin for the upcoming OHIF 3.9 and Cornerstone3D 2.0 to observe the migration process and take notes.

The AutoSegmentation works, but I doubt there's much left to do for the rest of it to function properly.

tangy5 commented 2 weeks ago

I can continue to work on making other part compatible to OHIF3.9. Looks like there will be bigger changes to switch 3.9 from 3.8. Will check one by one.

Thanks again for the guide.

sedghi commented 2 weeks ago

@tangy5 Yes, it's a significant change since Cornerstone3D 2.0 was released. It won't happen very often. https://www.cornerstonejs.org/docs/migration-guides/intro

SachidanandAlle commented 1 week ago

Let me work on this one time. I will take care from here. @sedghi you can help to review it once I submit the PR

SachidanandAlle commented 1 week ago

WIP: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

This should take care of most of the things. So far verified

  1. basic auto segmentation
  2. point prompts (deepgrow/deepedit/vista3d/sam2 models)
  3. class prompts (seg/vista models)

Need to add back new other things like Active Learning..

tangy5 commented 1 week ago

WIP: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

This should take care of most of the things. So far verified

  1. basic auto segmentation
  2. point prompts (deepgrow/deepedit/vista3d/sam2 models)
  3. class prompts (seg/vista models)

Need to add back new other things like Active Learning..

Great, after this is finished, I will add VISTA3D supports to OHIF 3.9. Thanks again.

sedghi commented 1 week ago

@SachidanandAlle yes, let me know when to review

sedghi commented 1 week ago

@SachidanandAlle, consider merging a formatting PR first to reduce the noise from numerous formatting fixes.

SachidanandAlle commented 1 week ago

@SachidanandAlle, consider merging a formatting PR first to reduce the noise from numerous formatting fixes.

https://github.com/Project-MONAI/MONAILabel/pull/1784

SachidanandAlle commented 6 days ago

@sedghi need your help. https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

I can run auto segmentation, point prompts (interactive for deepgrow/deepedit/sam2/vista3d) and also subset/class prompts. But on the main list monai-label mode is not active

However for testing, I can do right click and open and run things in monailabel. The button is disabled to open a studies in monai-label mode directly.

image

I might be missing some config in the init for extension/mode. need your help.

Otherwise TODO:

  1. Add back active learning section
  2. Add back settings table

image

sedghi commented 6 days ago

@SachidanandAlle Does your PR have my changes here? shall we close this one?

SachidanandAlle commented 6 days ago

Yes.. I have cherry picked the needed ones to support ohif latest. During this I might have missed something. That can be one reason for disabled button for monailabel mode

sedghi commented 6 days ago

Let's close this one, and I'll work on that one.

SachidanandAlle commented 6 days ago

Thanks :)