search

Project-MONAI / model-zoo

MONAI Model Zoo that hosts models in the MONAI Bundle format.
Apache License 2.0
179 stars 67 forks source link

Unify required properties in bundles #437

Closed yiheng-wang-nv closed 1 year ago

yiheng-wang-nv commented 1 year ago

monai.bundle.properties in this PR: https://github.com/Project-MONAI/MONAI/pull/6432 defines the new requirements of bundles. However, it has some differences of what we were defined in: https://github.com/Project-MONAI/model-zoo/blob/b72b9fbe80e999407d4d136207778a02f37d3c6d/CONTRIBUTING.md#preferred-files-and-keys

Especially for InferProperties which is for inference and evaluate config files. In current model zoo bundles, contributors usually include train.json and just override some components to build the evaluate.json (example). It conflicting to properties like "dataset", "dataset_data" and so on.

Nic-Ma commented 1 year ago

Please use TrainProperties to verify.

Thanks.