Project-MONAI / model-zoo

MONAI Model Zoo that hosts models in the MONAI Bundle format.
Apache License 2.0
179 stars 67 forks source link

update ldm noise scheduler api for inference #452

Closed Can-Zhao closed 1 year ago

Can-Zhao commented 1 year ago

Fixes # .

Description

update ldm noise scheduler api for inference

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

yiheng-wang-nv commented 1 year ago

Thanks @Can-Zhao , I will add the unit tests on these 2 bundles within this PR to prevent similar issues.

yiheng-wang-nv commented 1 year ago

Hi @Nic-Ma , when preparing the unit test of ldm bundles, I just found a place of ldm bundles that is not matched up with: https://github.com/Project-MONAI/MONAI/blob/e6ec945e4b87b90835cdad29ea64b1f27b8accda/monai/bundle/properties.py#L61

Some datasets may not have "data", such as all datasets in: https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/datasets.py or customized datasets.

Is it possible to change it into BundleProperty.REQUIRED: False ? Or ldm bundles should extend BundleWorkflow directly and define a customized workflow (within the unit test) ?

Nic-Ma commented 1 year ago

Hi @yiheng-wang-nv ,

That's a good point, I would suggest to change the required train_dataset_data into BundleProperty.REQUIRED: False in the properties. CC @SachidanandAlle and @tangy5 .

Thanks.

yiheng-wang-nv commented 1 year ago

Hi @yiheng-wang-nv ,

That's a good point, I would suggest to change the required train_dataset_data into BundleProperty.REQUIRED: False in the properties. CC @SachidanandAlle and @tangy5 .

Thanks.

I see. Hi @SachidanandAlle @tangy5 , do you think we can change the "BundleProperty.REQUIRED" of train_dataset_data? Are there any concerns here?

YanxuanLiu commented 1 year ago

/build

yiheng-wang-nv commented 1 year ago

/build