Project-MONAI / model-zoo

MONAI Model Zoo that hosts models in the MONAI Bundle format.
Apache License 2.0
186 stars 68 forks source link

Valve Landmark Bundle: Update to fix changes to EnsureChannelFirstd and further documentation #542

Closed ericspod closed 8 months ago

ericspod commented 9 months ago

Description

This fixes a discovered issue with the way transforms are used and adds a little more clarification to the documentation.

Status

Work in progress

Please ensure all the checkboxes:

yiheng-wang-nv commented 9 months ago

/build

yiheng-wang-nv commented 8 months ago

CI test failed because of the numpy version. I checked th numpy 1.26 requirements and it needs to run with Python >= 3.9 but now we use python 3.8 Hi @ericspod , do you think if we can use an elder numpy version for this bundle so far? It seems MONAI supported python versions is 3.8+ (https://raw.githubusercontent.com/Project-MONAI/MONAI/dev/docs/images/python.svg)

If numpy 1.26 is necessary, it may need @YanxuanLiu 's help to modify the python used for blossom CI and then we can rerun the test for this PR.

ericspod commented 8 months ago

Any version of Numpy that's recent should be fine actually so I've changed it to be 1.25.2.

yiheng-wang-nv commented 8 months ago

/build