search

Project-MONAI / model-zoo

MONAI Model Zoo that hosts models in the MONAI Bundle format.
Apache License 2.0
190 stars 67 forks source link

CI accepts --pre option to install rc version automatically #595

Closed mingxin-zheng closed 3 months ago

mingxin-zheng commented 3 months ago

Is your feature request related to a problem? Please describe.

The feature request is about CI of the bundles. When we are working on the rc version of MONAI, we will need to update the monai_version in the bundles to target the release candidate.

For example, @KumoLiu has this change in her PR: https://github.com/Project-MONAI/model-zoo/pull/575/files

The issue is we need to update the monai_version every time we have a new rc of monai, even though nothing needs to be changed in the bundle.

Describe the solution you'd like

Add an option use_rc_if_applicable in the CI scripts. When it's false, everything stays as it is. When it's true, it can accept the rc version if the official version is not released yet for CI runs.

For example, in release 1.4, when we want to start the release candidate, we can just put the monai_version in the bundles to 1.4. And the CI will actually install the latest 1.4 rc version.

We can keep the switch false most of the time, and only turn it on when the monai is in rc cycle.

mingxin-zheng commented 3 months ago

For vis @yiheng-wang-nv @KumoLiu @Nic-Ma