Project-MONAI / model-zoo

MONAI Model Zoo that hosts models in the MONAI Bundle format.
Apache License 2.0
186 stars 68 forks source link

Use same label dict file for vista3d bundle and tutorial #664

Open yiheng-wang-nv opened 1 week ago

yiheng-wang-nv commented 1 week ago

To avoid maintaining multiple files

tutorial: https://github.com/Project-MONAI/tutorials/blob/main/3d_segmentation/vista3d/vista3d_spleen_finetune.ipynb

KumoLiu commented 1 week ago

Also here: https://github.com/Project-MONAI/model-zoo/blob/dev/models/maisi_ct_generative/configs/label_dict.json https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/label_dict.json https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/docs/labels.json

yiheng-wang-nv commented 1 week ago

maisi:

    "dummy6": 129,
    "dummy7": 130,
    "dummy8": 131,

vista3d in model zoo:

    "kidney mass": 129,
    "liver tumor": 130,
    "vertebrae L6": 131,

vista3d tutorial:

    "kidney mass (deprecated)": 129,
    "liver tumor (deprecated)": 130,
    "vertebrae L6 (deprecated)": 131,

Hi @Can-Zhao @heyufan1995 , could you help to confirm if we can use a single version to cover all maisi and vista3d tutorials and bundles? Which version should we use?

mingxin-zheng commented 1 week ago

As we internally discussed before, it would be nice if we can have individual label JSON for each model. But the file should be visible publicly in MONAI tutorial repo and we should use commit hash in the link to ensure the right version to be called.

yiheng-wang-nv commented 1 week ago

vista3d is updated in #657