Project-MONAI / monai-deploy

MONAI Deploy aims to become the de-facto standard for developing, packaging, testing, deploying and running medical AI applications in clinical production.
Apache License 2.0
98 stars 22 forks source link

MD Express: Issues with .env and docker-compose file #141

Open chezhia opened 11 months ago

chezhia commented 11 months ago

There are 2 minor issues with the MD Express docker-compose.yml and .env file that prevents launching the services without modifications:

  1. In the .env file, the TASK_MANAGER_DATA has an additional $PWD that is not present in other DATA variables and throws an error when launched. The error arises due to docker-compose assuming $PWD as a named volume.

Named volume "$PWD/.md/mdtm:/var/lib/monai:rw" is used in service "task-manager" but no declaration was found in the volumes section.

Edit - Saw this issue in the FAQ section, Why does only the TASK_MANAGER_DATA need $PWD though? isn't .md/ already assuming the docker-compose up is run from the MDE working directory?

  1. If the idea is to use the .env file to set the desired data directories, the data volume for elasticsearch service should also be defined there, instead of directly assigning it to .md/esdata in the docker-compose.yml file.