search

Project-MONAI / monai-deploy

MONAI Deploy aims to become the de-facto standard for developing, packaging, testing, deploying and running medical AI applications in clinical production.
Apache License 2.0
97 stars 22 forks source link

MAP: Add MONAI_WORKDIR to MAP's environment #28

Closed gigony closed 3 years ago

gigony commented 3 years ago

The information of Working directory path is needed in MONAI Application SDK to play with the intermediate files.

This patch specifies the MONAI_WORKDIR environment variable and fix typos (/var/opt/monai -> /opt/monai and /etc/monai/models -> /opt/monai/models)

This environment variable would be used in https://github.com/Project-MONAI/monai-app-sdk/pull/88

whoisj commented 3 years ago

Why would anyone need this environment variable? $PWD will be set the working directory.

Rather confused here. 🤔

Additionally, as the MAP specification author it would have been polite to add me as a reviewer.

gigony commented 3 years ago

Why would anyone need this environment variable? $PWD will be set the working directory.

Rather confused here. 🤔

@whoisj ,

PWD is referring to the 'current' working directory and it is not persistent and prone to change during the execution. (For example, in MONAI App SDK, we switch the current working directory during its execution to provide a specific current working directory to work for each operator.)

For this reason, the persistent environment variable to get the original working directory is needed and it should be separated from the general environment variable -- PWD.

Additionally, as the MAP specification author it would have been polite to add me as a reviewer.

Didn't I add you as a reviewer as well as mention you in this PR? (I remember I added you, Kavin and Ming as reviewers and the evidence is below ;) ).

image

The model path have various values, we should reconcile to a single value before completing this PR.

Let me check and update it.