search

Project-MONAI / research-contributions

Implementations of recent research prototypes/demonstrations using MONAI.
https://monai.io/
Apache License 2.0
1.03k stars 336 forks source link

SwinUNETR on BTCV with unused CLI arguments #63

Closed razorx89 closed 2 years ago

razorx89 commented 2 years ago

Describe the bug The training script for SwinUNETR on BTCV includes CLI arguments for smoothing coefficients in the Dice loss. However, those coefficients are never used. Were they used for training the original models reported in the publication?

https://github.com/Project-MONAI/research-contributions/blob/46279a9601852a1e5f3a2581fa32be403f57885e/SwinUNETR/BTCV/main.py#L78-L79

https://github.com/Project-MONAI/research-contributions/blob/46279a9601852a1e5f3a2581fa32be403f57885e/SwinUNETR/BTCV/main.py#L144-L146

@ahatamiz

ahatamiz commented 2 years ago

Hi @razorx89

Thanks for the comment. Those coefficients particularly were intended to be used for squared Dice loss. However, we did not use it for training the models whose benchmarks are reported in the papers. I have submitted a PR with the option of using squared Dice loss, in case you would like to give it a try.

Best,

razorx89 commented 2 years ago

Thanks.