Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.84k stars 679 forks source link

Update "pathology/tumor_detection/ignite/profiling_camelyon_pipeline.ipynb" #1673

Closed KumoLiu closed 7 months ago

KumoLiu commented 7 months ago

Fixes # .

Description

Update the usage of nvtx in "tumor_detection_camelyon"

Checks

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

drbeh commented 7 months ago

@KumoLiu I see an error in the CI but I don't see it when running locally. Can it be due the installed nsight version? Can you take a look before merging?

ericspod commented 7 months ago

The complaint is FileNotFoundError: [Errno 2] No such file or directory: 'profile_report_nvtx_pushpop_sum.csv'. It looks like this file is generated by the nsys call, maybe this isn't running now for some reason? The name changes in the PR look correct.

KumoLiu commented 7 months ago

It’s wired, I don’t see any reason why the file is not exist. Also, what could be the reasons for it not executing immediately.

ericspod commented 7 months ago

I would think papermill would run all command invocations otherwise many other notebooks would fail. How large is the generated csv? If the container runs out of space and tries to write the file it may silently do nothing, but this file would have to be really big. We could have a check right after nsys stats to check that the file was created: assert os.path.isfile("profile_report_nvtx_pushpop_sum.csv"). For testing in the CICD environment we could temporarily add !ls -lh right before that to see what the file structure looks like.

KumoLiu commented 7 months ago

works well in the 24.02 PyTorch image, close for now.