search

Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.74k stars 662 forks source link

Fedn example #1732

Closed sztoor closed 1 month ago

sztoor commented 2 months ago

Description

This PR contains an example of how the MONAI centralized 2D classification example can run using the FEDn framework. We have created a subdirectory in the federated_learning directory and provided a README file.

KumoLiu commented 1 month ago

Hi @sztoor, thanks for the PR, could you please fix the DCO issue with the recommended suggestions? https://github.com/Project-MONAI/tutorials/pull/1732/checks?check_run_id=26545667988

sztoor commented 1 month ago

Done! Do you want me to create a new PR?

/Salman.

On Tue, Jun 25, 2024 at 9:34 PM YunLiu @.***> wrote:

Hi @sztoor https://github.com/sztoor, thanks for the PR, could you please fix the DCO issue with the recommended suggestions?

https://github.com/Project-MONAI/tutorials/pull/1732/checks?check_run_id=26545667988

— Reply to this email directly, view it on GitHub https://github.com/Project-MONAI/tutorials/pull/1732#issuecomment-2189824100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4XSJ47XW6M4DC4P5NYVDZJHA4VAVCNFSM6AAAAABJXE5FK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZHAZDIMJQGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Salman Toor, PhD Uppsala University, Sweden.

sztoor commented 1 month ago

Sorry, the problem still exists. Let me do it from scratch and make a new PR.

/Salman.

On Wed, Jun 26, 2024 at 5:32 PM Salman Toor @.***> wrote:

Done! Do you want me to create a new PR?

/Salman.

On Tue, Jun 25, 2024 at 9:34 PM YunLiu @.***> wrote:

Hi @sztoor https://github.com/sztoor, thanks for the PR, could you please fix the DCO issue with the recommended suggestions?

https://github.com/Project-MONAI/tutorials/pull/1732/checks?check_run_id=26545667988

— Reply to this email directly, view it on GitHub https://github.com/Project-MONAI/tutorials/pull/1732#issuecomment-2189824100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4XSJ47XW6M4DC4P5NYVDZJHA4VAVCNFSM6AAAAABJXE5FK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZHAZDIMJQGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Salman Toor, PhD Uppsala University, Sweden.

-- Salman Toor, PhD Uppsala University, Sweden.

KumoLiu commented 1 month ago

Hi @sztoor, I don't think you need to recreate the PR, just follow the DCO guide with commit info like this:

DCO Remediation Commit for root <root@instance-20240510-133634.us-central1-a.c.salman-test-project.internal>

I, root <root@instance-20240510-133634.us-central1-a.c.salman-test-project.internal>, hereby add my Signed-off-by to this commit: 0ea2638ea3098ad1542f95b1446aa9e073fc53d3
I, root <root@instance-20240510-133634.us-central1-a.c.salman-test-project.internal>, hereby add my Signed-off-by to this commit: 1ae7020566e5fdb0545a24b4491353f729e880b2

Signed-off-by: root <root@instance-20240510-133634.us-central1-a.c.salman-test-project.internal>
sztoor commented 1 month ago

hi,

I tried but it seems the DCO check was not clear. So I cleaned everything and created a new PR. There I see that the DCO check was successfully cleared.

/Salman.

On Thu, Jun 27, 2024 at 6:41 AM YunLiu @.***> wrote:

Hi @sztoor https://github.com/sztoor, I don't think you need to recreate the PR, just follow the DCO guide with commit info like this:

DCO Remediation Commit for root @.***>

I, root @.>, hereby add my Signed-off-by to this commit: 0ea2638ea3098ad1542f95b1446aa9e073fc53d3 I, root @.>, hereby add my Signed-off-by to this commit: 1ae7020566e5fdb0545a24b4491353f729e880b2

Signed-off-by: root @.***>

— Reply to this email directly, view it on GitHub https://github.com/Project-MONAI/tutorials/pull/1732#issuecomment-2193684102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4XSIM6DDJXJAFRDR53HLZJOJZHAVCNFSM6AAAAABJXE5FK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGY4DIMJQGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Salman Toor, PhD Uppsala University, Sweden.