search

Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.74k stars 662 forks source link

Adding a FEDn example to the MONAI tutorial repository. #1740

Closed sztoor closed 1 month ago

sztoor commented 1 month ago

Description

This PR is to include a FEDn based federated learning example to the list of MONAI tutorials.

ericspod commented 1 month ago

Hi @sztoor @KumoLiu This PR only adds a readme file describing where to go for the example tutorial. Would it be possible to add the linked tutorial directly here instead, assuming the license was compatible with our Apache2 license? I don't see this being a significant addition otherwise.

sztoor commented 1 month ago

Hi Eric,

I think this is a suitable way of contributing a working example for an extended period. If I add more content to your tutorial repository, it may eventually break due to new updates, making it difficult for us to keep track of external repositories. The contribution is significant because we have prepared an example familiar to the MonAI community.

As you know, this whole effort will only be useful if the example is continuously tested and available in working condition. I think including one README in your repository is a much more sustainable way to provide a working example. Additionally, the other examples in the "federated_learning" directory follow the same pattern.

/Salman.

holgerroth commented 1 month ago

Hi Eric, I think this is a suitable way of contributing a working example for an extended period. If I add more content to your tutorial repository, it may eventually break due to new updates, making it difficult for us to keep track of external repositories. The contribution is significant because we have prepared an example familiar to the MonAI community. As you know, this whole effort will only be useful if the example is continuously tested and available in working condition. I think including one README in your repository is a much more sustainable way to provide a working example. Additionally, the other examples in the "federated_learning" directory follow the same pattern. /Salman.

Yes, this is the pattern we follow in the federated learning tutorials, as each will depend on a different FL framework, and maintaining the examples in the FL framework repos is easier long term.

@sztoor, please apply the suggested changes to merge this PR.

sztoor commented 1 month ago

Hi,

I have already applied the suggested changes.

I am on vacations, will be back on 15th.

/Salman

On Mon, Jul 8, 2024, 22:58 Holger Roth @.***> wrote:

Hi Eric, I think this is a suitable way of contributing a working example for an extended period. If I add more content to your tutorial repository, it may eventually break due to new updates, making it difficult for us to keep track of external repositories. The contribution is significant because we have prepared an example familiar to the MonAI community. As you know, this whole effort will only be useful if the example is continuously tested and available in working condition. I think including one README in your repository is a much more sustainable way to provide a working example. Additionally, the other examples in the "federated_learning" directory follow the same pattern. /Salman.

Yes, this is the pattern we follow in the federated learning tutorials, as each will depend on a different FL framework, and maintaining the examples in the FL framework repos is easier long term.

@sztoor https://github.com/sztoor, please apply the suggested changes to merge this PR.

— Reply to this email directly, view it on GitHub https://github.com/Project-MONAI/tutorials/pull/1740#issuecomment-2215098749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4XSMGNHAWSJLA5OUXIMDZLLVPXAVCNFSM6AAAAABJ6F3MBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJVGA4TQNZUHE . You are receiving this because you were mentioned.Message ID: @.***>