Closed Can-Zhao closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I'd like to outline a few points for consideration regarding the current PR:
erode3d
, dilate3d
, and closing
functions and incorporate them into the MONAI core.I would suggest to change from "generative" to "generation" or "3d_generation" following folder structures of other tutorials. @Can-Zhao
@guopengf Hi Pengfei, I saw you have defined a few plotting funcs in mask_augmentation_example.ipynb Do you think it would be better to move them to somewhere like scripts/utils_plot.py? So all the other notebooks can use those plot funcs. Thank you!
The CI premerge-notebooks
indicates the installation of monai-generative
fails
To fix the imports and CI errors, I would suggest to do the following:
!python -c "import monai" || pip install -q "monai-weekly[nibabel, tqdm]"
!python -c "import generative; print(generative.__version__)" || pip install -q "monai-generative"
To fix the imports and CI errors, I would suggest to do the following:
!python -c "import monai" || pip install -q "monai-weekly[nibabel, tqdm]" !python -c "import generative; print(generative.__version__)" || pip install -q "monai-generative"
Thank. It seems CI error still exists...I was wondering if you have any idea on how to fix it. Thank you!
It is very likely that the CI environment (V100 16G) cannot support the notebook testing because:
xformers
version compiled for the right arch
Fixes # .
Description
MAISI inference utility functions.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>