Maisi readme - Githubissues

Project-MONAI / tutorials

MONAI Tutorials

https://monai.io/started.html

Apache License 2.0

1.74k stars 662 forks source link

Maisi readme #1743

Closed Can-Zhao closed 3 weeks ago

Can-Zhao commented 1 month ago

Fixes # .

Description

Maisi readme.

Checks

[ ] Avoid including large-size files in the PR.
[ ] Clean up long text outputs from code cells in the notebook.
[ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key.
[ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
[ ] Notebook runs automatically ./runner.sh -t <path to .ipynb file>

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mingxin-zheng commented 1 month ago

Hi @Can-Zhao @KumoLiu , shall we rename the generative folder into generative_models or generation in this PR? It seems a good timing as we don't have other active PRs

git mv generative generative_models

(My comment is only applicable if this PR will be finished in a day or less)

Can-Zhao commented 1 month ago

Hi @Can-Zhao @KumoLiu , shall we rename the generative folder into generative_models or generation in this PR? It seems a good timing as we don't have other active PRs
git mv generative generative_models
(My comment is only applicable if this PR will be finished in a day or less)

Yes, I agree

KumoLiu commented 3 weeks ago

Hi @Can-Zhao, please help renamed the generative dir to generation and modify the related "Setup environment" section. Thanks!

Can-Zhao commented 3 weeks ago

Hi @Can-Zhao, please help renamed the generative dir to generation and modify the related "Setup environment" section. Thanks!

I will change it after all other comments are resolved. Or we can open another PR to do it to make it more tractable