search

Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.74k stars 662 forks source link

Add tutorial to demonstrate how to train a generative model that can generate large image volumes #1745

Closed dongyang0122 closed 1 month ago

dongyang0122 commented 1 month ago

Fixes #1744.

Description

Add tutorial to demonstrate how to train a generative model that can generate large image volumes.

Checks

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mingxin-zheng commented 1 month ago

Hi @dongyang0122 , some signature is missing: https://github.com/Project-MONAI/tutorials/pull/1745/checks?check_run_id=27169416504

Summary
Commit sha: [f159834](https://github.com/Project-MONAI/tutorials/pull/1745/commits/f1598348036b7d64267f1c7a8f1fa76d4a5d37aa), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [50d0382](https://github.com/Project-MONAI/tutorials/pull/1745/commits/50d0382c5194f2eb185d0a7dceea148eaec406da), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e818c46](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e818c46d56d40cca03fdaca1d7db82577fccf172), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e033503](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e03350303104d65254f84ca482b752ac83f1de48), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e41d619](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e41d6197c989de35751f53b0a662d9f0a7ef344c), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [d78b35a](https://github.com/Project-MONAI/tutorials/pull/1745/commits/d78b35a1f230319fb898b68c41ccabe29b1d9c27), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [a5de734](https://github.com/Project-MONAI/tutorials/pull/1745/commits/a5de734e08ffc74e5bada4b4cef5e2f62c2d02cf), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [79d620f](https://github.com/Project-MONAI/tutorials/pull/1745/commits/79d620f0210281b7d09a1827cfe88b9606f9ad4d), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [74f69a4](https://github.com/Project-MONAI/tutorials/pull/1745/commits/74f69a4d34ff116c498913c98c9af135f62bc47b), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [3268421](https://github.com/Project-MONAI/tutorials/pull/1745/commits/32684213f89da42fdef71b3709948693a693bc59), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [5847ed8](https://github.com/Project-MONAI/tutorials/pull/1745/commits/5847ed823621d4a3f970058ae7b1c611a9f4c5d6), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
KumoLiu commented 1 month ago

Hi @dongyang0122, could you please take a look at the ci issue? You can see the error using details. Thanks!

mingxin-zheng commented 1 month ago

Shall we add some doc to explain how/where to run the diff-model_{infer/train}.py later (since the markdown is removed from the PR)

dongyang0122 commented 1 month ago

Shall we add some doc to explain how/where to run the diff-model_{infer/train}.py later (since the markdown is removed from the PR)

There will be a README PR later. We will add this information in the unified README file.

Can-Zhao commented 1 month ago

The model architecture is also defined in 'config_maisi.json'. Do you think we can reuse it and avoid duplicate network definition?

dongyang0122 commented 1 month ago

The model architecture is also defined in 'config_maisi.json'. Do you think we can reuse it and avoid duplicate network definition?

Hi @Can-Zhao, I have updated the scripts to reuse model definition from config_maisi.json. Thanks for suggestion.

KumoLiu commented 1 month ago

Hi @KumoLiu , is it necessary to push another commit by @dongyang0122 ?

No, should be fine for now.