Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.88k stars 683 forks source link

Port Existing Generative Tutorials #1769

Closed ericspod closed 2 weeks ago

ericspod commented 3 months ago

Is your feature request related to a problem? Please describe. We have the following to port:

Let's divide amongst assignees and go from there. For each tutorial in the generative repo we should:

  1. Copy over the .ipynb file and not the .py file made with papermill, only those .py files that were written as such (I think distributed_training/ddpm_training_ddp.py is the only one).
  2. Change references from components in GenerativeModels to those in MONAI.
  3. Verify the tutorial still works.
  4. Fix any bugs.
virginiafdez commented 3 months ago

Most of the tutorials merely require the changes mentioned above except for the following:

Nic-Ma commented 3 months ago

Hi @ericspod ,

As our ETA is end of this month, could you please help split the tasks directly based on the effort in your mind? @virginiafdez @yiheng-wang-nv should be the experts to help here.

Thanks in advance.

virginiafdez commented 3 months ago

I will take on the porting of 2d_spade_gan and 2D_spade_ldm, as well as 3d_brainsmask_controlnet from August 17th onwards, as per what I discussed in my previous comment.

Nic-Ma commented 3 months ago

I will take on the porting of 2d_spade_gan and 2D_spade_ldm, as well as 3d_brainsmask_controlnet from August 17th onwards, as per what I discussed in my previous comment.

Hi @yiheng-wang-nv , could you please help also pick several of the tutorials to port?

Thanks in advance.

ericspod commented 3 months ago

I'm going to start with the 2D and 3D LDM tutorials in GenerativeModels. These are single notebooks which differ significantly in content from the existing LDM tutorials (https://github.com/Project-MONAI/tutorials/tree/main/generative/2d_ldm and https://github.com/Project-MONAI/tutorials/tree/main/generative/3d_ldm), so we have 4 tutorials here to check. I'll make sure the ones from GenerativeModels work first then those already here, and see how to best combine both.

yiheng-wang-nv commented 3 months ago

I will work in the order of:

Will update this ticket when having any progrsses

Nic-Ma commented 3 months ago

Hi @ericspod ,

Thanks for your testing here, may I know why you want to test the "2D and 3D LDM tutorials in GenerativeModels"? I think maybe we can start the MONAI tutorials directly?

Thanks.

ericspod commented 3 months ago

may I know why you want to test the "2D and 3D LDM tutorials in GenerativeModels"?

These should be fast to check and then move over, the ones in tutorials are move involved and I need to go over them at the same time to be sure they aren't essentially duplicating what is being demonstrated.

pedrob37 commented 3 months ago

I'll start working on anomaly_detection for now, and I'll likely get around to a few more next week

ericspod commented 2 months ago

I'm going to pick up the other 2D tutorials, hopefully these will be fast. the 3D DDPM tutorial works but I can't get good results out of it for some reason so far.

ericspod commented 3 weeks ago

3D DDPM tutorial is now up for review, it works now reliably.

ericspod commented 2 weeks ago

The last item in our list can be addressed separately so I'm going to call this issue completed.