Project-MONAI / tutorials

MONAI Tutorials
https://monai.io/started.html
Apache License 2.0
1.76k stars 667 forks source link

Port LDM Tutorials #1775

Closed ericspod closed 1 month ago

ericspod commented 1 month ago

Addresses part of #1769.

Description

This updates the tutorials for LDM models and copies over the notebooks from the GenerativeModels repo. These notebooks have been checked, the 3D one has its code updated but cell outputs left as-is to save time so may need checking later. The MAISI tutorial was untouched but should be updated as well.

Checks

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Can-Zhao commented 1 month ago

Thank you so much for the PR! May I ask if you have run the tutorials for LDM models, including the multi-gpu script? LGTM. Thank you!

KumoLiu commented 1 month ago

Hi @ericspod, please help remove the output from these cells to help resolve the ci issue. https://github.com/Project-MONAI/tutorials/actions/runs/10357197347/job/28668716848?pr=1775

KumoLiu commented 1 month ago

Still one more place need to update: https://github.com/Project-MONAI/tutorials/actions/runs/10369757784/job/28706169443?pr=1775

ericspod commented 1 month ago

The guidelines should be met now, we should check that the max_epochs replacement is working and things aren't too slow.

KumoLiu commented 1 month ago

I find there are still one place in ldm need to be updated: https://github.com/Project-MONAI/tutorials/blob/main/generation/3d_ldm/inference.py#L23

KumoLiu commented 1 month ago

cc @ericspod @Can-Zhao