Closed ericspod closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thank you so much for the PR! May I ask if you have run the tutorials for LDM models, including the multi-gpu script? LGTM. Thank you!
Hi @ericspod, please help remove the output from these cells to help resolve the ci issue. https://github.com/Project-MONAI/tutorials/actions/runs/10357197347/job/28668716848?pr=1775
Still one more place need to update: https://github.com/Project-MONAI/tutorials/actions/runs/10369757784/job/28706169443?pr=1775
The guidelines should be met now, we should check that the max_epochs
replacement is working and things aren't too slow.
I find there are still one place in ldm need to be updated: https://github.com/Project-MONAI/tutorials/blob/main/generation/3d_ldm/inference.py#L23
cc @ericspod @Can-Zhao
Addresses part of #1769.
Description
This updates the tutorials for LDM models and copies over the notebooks from the GenerativeModels repo. These notebooks have been checked, the 3D one has its code updated but cell outputs left as-is to save time so may need checking later. The MAISI tutorial was untouched but should be updated as well.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>