search

Project-OMOTES / orchestrator

GNU General Public License v3.0
0 stars 0 forks source link

35: Move orchestrator db schema here and rewire integration test to u… #36

Closed lfse-slafleur closed 4 months ago

lfse-slafleur commented 5 months ago

…se computation engine as a submodule.

Needs to be coordinated with https://github.com/Project-OMOTES/computation-engine/pull/43

lfse-slafleur commented 4 months ago 
* There are a lot of console prints during the integration test, this would probably make it harder to track down issues. Is it possible to reduce the prints?

Quieted down by setting the log level.

* Should we divide `unit_test/test_main.py` into several files?

I would vote not yet. This PR is quite big already. Also, a large test file is usually a sign the 'file under test' (main.py) is too big and should be split up. In other words, if we split up main.py, the unit test file will be reduced as well. But I would vote to do this later.

* I really appreciate your effort in creating 'win32' cmd files, however I don't use them.. Since two weeks I run everything under WSL (file system and venv) and before I was using 'git bash' for the shell scripts. So as far as I am concerned we can leave out these cmd files. It is much better to develop with the same scripts as will be used on ci.

Michiel requires them.

lfse-slafleur commented 4 months ago

Also, there remains an issue that sometimes causes the integration test to fail. It is an issue within aio-pika. I have captured the issue here https://github.com/mosquito/aio-pika/issues/630 and will solve it myself. Unsure when it gets solved and merged in. Should not be an issue on production systems as the main reason it fails in the integration test is because the jobs finish so extremely fast. Jobs within omotes takes at least a couple of seconds at the moment. Should be fixed ASAP (high priority). Reminder captured here: https://github.com/Project-OMOTES/orchestrator/issues/37

MarkTNO commented 4 months ago

Thanks for resolving!
One more question about the win cmd files. Would Michiel be able to work with the bash files in git bash or powershell?

If not, should we provide cmd equivalents for all scripts? For instance the integration_test/ci scripts? And all scripts in the computation engine?

lfse-slafleur commented 4 months ago

Thanks for resolving! One more question about the win cmd files. Would Michiel be able to work with the bash files in git bash or powershell?

If not, should we provide cmd equivalents for all scripts? For instance the integration_test/ci scripts? And all scripts in the computation engine?

I am not sure exactly what his current working process is but I know he can work with cmd and ps files. Eventually when we uses the other scripts, I propose we port them then. For now, I ported the 'easy' ones already.