search

Project-OMOTES / rtc-tools-heat-network

GNU Lesser General Public License v3.0
1 stars 2 forks source link

Bug: equation for max_heat capacity #151

Open KelbijStarDeltares opened 3 months ago

KelbijStarDeltares commented 3 months ago

In code (esdl_heat_model.py)

    min_heat = capacity * min_fraction_tank_volume
    max_heat = capacity * (1 + min_fraction_tank_volume)
    assert max_heat > 0.0

This must be:

    min_heat = capacity * min_fraction_tank_volume
    max_heat = capacity * (1 **-** min_fraction_tank_volume)
    assert max_heat > 0.0
KelbijStarDeltares commented 3 months ago

Same here:

    # We assume that the height equals the radius of the buffer.
    r = (
        capacity
        * (1 + min_fraction_tank_volume)
        / (self.rho * self.cp * (supply_temperature - return_temperature) * math.pi)
    ) ** (1.0 / 3.0)