Project-OMOTES / simulator-core

Core library for NWN simulator
GNU General Public License v3.0
1 stars 0 forks source link

Decision on unit system for simulator and simulator-core #10

Closed MichielTukker closed 4 months ago

MichielTukker commented 1 year ago

Simulator/Simulator-core will be using SI unit system internally and for its output.

Questions:

edwinmat commented 1 year ago

There's two answers. And they both relate to the ESDL language (The MapEditor just follows the ESDL 'conventions'):

image

W.r.t. the databases.... It could be the case (but I don't have the complete overview) that all information in a database is referenced to from an ESDL. Then the ESDL indicates what unit is meant.

lfse-slafleur commented 10 months ago

@MichielTukker For what interactions do you expect to need access to the postgresql db? (or are you referring to a different db?) We of course also have the protocol between frontend/backend en between the orchestrator and worker/simulator. Whatever units choose, lets try to be consistent. I would be more than happy to just use SI everywhere we can/is relevant. Specifically timestamps I would propose to use unix epoch.

vanmeerkerk commented 6 months ago

@MichielTukker and @samvanderzwan can we close this issue?

samvanderzwan commented 4 months ago

Yes, Internally omotes simualotr core will use SI. Conversion will be done at import, when needed

samvanderzwan commented 4 months ago

Will close this issue

edwinmatthijssen commented 1 month ago

Just came back from holidays, not sure if replying to the email is still required (and works) but I’ll give it a try.

In MapEditor/ESDL there are two cases:

From: Michiel Tukker @.> Sent: donderdag 5 oktober 2023 15:39 To: Nieuwe-Warmte-Nu/simulator-core @.> Cc: Matthijssen, E.F. (Edwin) @.>; Mention @.> Subject: [Nieuwe-Warmte-Nu/simulator-core] Decide on unit system for simulator simulator-core (Issue #10)

Simulator/Simulator-core will be using SI unit system internally and for its output.

Questions:

— Reply to this email directly, view it on GitHubhttps://github.com/Nieuwe-Warmte-Nu/simulator-core/issues/10, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKJ4KQ7DQ5NZ3NGZ3LWTMRDX522AHAVCNFSM6AAAAAA5UI7QSCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZDQMZRG4ZTCNI. You are receiving this because you were mentioned.Message ID: @.**@.>>

-- This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.