Project-OMOTES / simulator-core

Core library for NWN simulator
GNU General Public License v3.0
1 stars 0 forks source link

Refactor _colebrook_white friction factor method #178

Closed vanmeerkerk closed 1 day ago

vanmeerkerk commented 2 days ago

An implicit method is currently implemented that uses a root-finding algorithm to determine the friction factor. The implicit method is computationally 'expensive' and could be replaced with an explicit formulation. See for example the table of approximations https://en.wikipedia.org/wiki/Darcy_friction_factor_formulae

Steps:

  1. Investigate whether the Tkachenko, Mileikovskyi (2020) explicit formulation is applicable in our case.
  2. Implement the chosen explicit formulation.
  3. Fluid properties should be based on u1 or inflowing node temperature (see #177)