Project-OMOTES / user_feedback

Repository to hold all feedback (bugs and feature request) from users
1 stars 0 forks source link

[Bug]: Asset polygons remain in ESDL file when reloading. #31

Closed JurrianVRHDHV closed 1 month ago

JurrianVRHDHV commented 4 months ago

Is there an existing issue for this?

What happened?

During the drawing of a network, I used the draw asset as a polygon tool to create various clusters. Whilst drawing I made various mistakes (wrong shape, location, asset type) and tried to delete both the asset point and polygon layers. The toolkit lets me delete the polygon and point layers visually. After which I use the draw asset to draw a new (corrected) polygon. When reloading the file the deletion is undone, causing an overlap of old and new polygons and points.

Example of resulting overlapping layers due to incorrect removal afbeelding

This happens regardless of saving and reloading or restarting the browser/PC/map editor/using a different browser)

Steps to reproduce the problem

  1. Open ESDL map editor

  2. Unzip and open file [ESDL_DenHaag_V2.3.47_ERRORFILE.esdl] in the map editor ESDL_DenHaag_V2.3.47_ERRORFILE.zip

  3. Select 'Delete Layers' in toolbar

  4. Delete (one of the) various incorrect (visible as overlapping) polygons afbeelding afbeelding afbeelding afbeelding

  5. Check 'Save' on the 'Delete Layers' tooloption

  6. Save ESDL-file to local system

  7. Optionally: remove the EnergySystem from the top right ESDL layers

  8. Close map editor/browser (and restart PC)

  9. Open new ESDL map editor

  10. Load the saved ESDL file

  11. Check if point and polygon layers have been correctly removed.

What should have happened?

The various deleted polygon- and point layers should remain deleted after saving and reloading the ESDL file.

What browsers do you use to access the UI?

Mozilla Firefox

Additional information

No response

ewoudwerkman commented 1 month ago

Also nice catch! Deleting of a polygon of an asset was only done in the frontend, nothing happened in the backend. This is now fixed by adding a deletion event to the polygon of this asset. Fixed in next MapEditor release (24.6)