search

Project-OMOTES / user_feedback

Repository to hold all feedback (bugs and feature request) from users
1 stars 0 forks source link

[Bug]: Polygon has flow direction indicators #34

Closed JurrianVRHDHV closed 1 month ago

JurrianVRHDHV commented 4 months ago

Is there an existing issue for this?

What happened?

Hovering over or selecting a polygon layers of which the asset point has been connected to a supply pipeline shows a flow direction.

Screenshot (32)

Whilst this is logical for a

Steps to reproduce the problem

  1. Open ESDL Map Editor

  2. Select asset type [used generic consumer]

  3. Draw a new area/asset as a polygon using the draw polygon tool.

  4. Finish drawing the polygon

  5. Select 'pipe' in the topbar menu and use the draw "a cable or a pipe" toolkit option to draw a pipe connected to the input of the polygon asset.

  6. Finish drawing the line

  7. Go to the Edit topbar menu and select 'Energy carriers'

  8. Select Heat commodity, fill in the name [Test], Supply temp. [70] and return temp. [40] and click add. afbeelding

  9. Rightclick on the line to open the options menu and select 'Set Carrier'.

  10. Select the added [Test] Carrier.

  11. The [now default red collored polygon should show directional arrows on the outline. afbeelding

What should have happened?

The asset polygon should match the color of the set carrier (including outline and infil), but its outline should not have directional arrows

What browsers do you use to access the UI?

Mozilla Firefox

Additional information

After testing a bit with Sam, we found that the color change and directional arrows are set to the input carrier and not dependent on other connected carriers.

edwinmatthijssen commented 4 months ago

Interesting bug.... assets "as polygons" has not been used extensively before, so multiple bugs might be still present

ewoudwerkman commented 1 month ago

Issue existed because in Leaflet polygons are subclasses of polylines, so the MapEditor applied the styles of the carrier to it (including arrows) similar to lines (pipes/cables). This has now been resolved, as these polygons should not change color (areas do not have a carrier), but keep the color they have (usually green for assets) Fixed in next release (24.6)